Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpha parameter to ppi_mean_ci call #5

Merged

Conversation

PierreBoyeau
Copy link
Contributor

The alpha parameter did not propagate when lhat=None.
This PR is a quickfix to make sure it does.

@aangelopoulos
Copy link
Owner

You're a hero, Pierre. Thank you <3
Can you do the same for the other CIs, if it is missing?
Then I'll merge.

@PierreBoyeau
Copy link
Contributor Author

I had a quick look at the rest of the codebase, I did not find any similar issues elsewhere.

@aangelopoulos aangelopoulos merged commit 8066bab into aangelopoulos:main Feb 1, 2024
1 check failed
@aangelopoulos
Copy link
Owner

Great. I agree. MERGE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants