Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of EkfacInfluence #606

Open
schroedk opened this issue Jun 20, 2024 · 0 comments
Open

Refactoring of EkfacInfluence #606

schroedk opened this issue Jun 20, 2024 · 0 comments
Assignees
@schroedk
Labels
breaking-change Changes to the API cleanup when code is ugly or unreadable and needs restyling
Milestone
v0.11.0

Comments

@schroedk
Copy link
Collaborator

By now, there is the inheritance TorchInfluenceFunctionModel->EkfacInfluence
and EkfacInfluence is the only existing subclass.

In order to reduce code duplication:

  • Check, if it makes sense to inherit from TorchComposableInfluence
  • If not, integrate functionality from base class TorchInfluenceFunctionModel
    into EkfacInfluence
  • Remove abstract base class TorchInfluenceFunctionModel
@schroedk schroedk added cleanup when code is ugly or unreadable and needs restyling breaking-change Changes to the API labels Jun 20, 2024
@schroedk schroedk added this to the v0.11.0 milestone Jun 20, 2024
@schroedk schroedk self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schroedk schroedk

Labels
breaking-change Changes to the API cleanup when code is ugly or unreadable and needs restyling
Projects
None yet
Milestone
v0.11.0
Development

No branches or pull requests
1 participant
@schroedk