Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code duplication #384

Closed
kosmitive opened this issue Jul 27, 2023 · 2 comments
Closed

Remove code duplication #384

kosmitive opened this issue Jul 27, 2023 · 2 comments
Labels
cleanup when code is ugly or unreadable and needs restyling invalid Issue doesn't seem right or is no longer valid

Comments

@kosmitive
Copy link
Contributor

The pull request https://github.com/appliedAI-Initiative/pyDVL/pull/372/files and pull request #338 contain code duplication as they both use the sequential executor framework. These need to be unified, but it can't be addressed prior to merging at least on of them to develop.
@AnesBenmerzoug AnesBenmerzoug added the meta An issue used to collect and track other issues label Jul 27, 2023
@kosmitive
Copy link
Contributor Author

Related to #387

@mdbenito mdbenito added invalid Issue doesn't seem right or is no longer valid cleanup when code is ugly or unreadable and needs restyling and removed meta An issue used to collect and track other issues labels Aug 19, 2023
@mdbenito
Copy link
Collaborator

Closing because whatever choice is made in #387 will inevitably lead to rewriting and unification of duplicated code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup when code is ugly or unreadable and needs restyling invalid Issue doesn't seem right or is no longer valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdbenito @kosmitive @AnesBenmerzoug