From 1482b72be2a8ae608805d577e4983def9004b7ab Mon Sep 17 00:00:00 2001
From: Nicholas Junge <nicholas.junge@web.de>
Date: Sat, 26 Oct 2024 11:22:31 +0200
Subject: [PATCH] Remove context tests and imports in optional duckDB reporter

---
 src/nnbench/reporter/duckdb_sql.py |   4 +-
 tests/test_context.py              | 108 -----------------------------
 tests/test_fileio.py               |   3 +-
 3 files changed, 2 insertions(+), 113 deletions(-)
 delete mode 100644 tests/test_context.py

diff --git a/src/nnbench/reporter/duckdb_sql.py b/src/nnbench/reporter/duckdb_sql.py
index 12a169a4..ce9a5656 100644
--- a/src/nnbench/reporter/duckdb_sql.py
+++ b/src/nnbench/reporter/duckdb_sql.py
@@ -5,8 +5,6 @@
 import weakref
 from pathlib import Path
 
-from nnbench.context import Context
-
 try:
     import duckdb
 
@@ -122,7 +120,7 @@ def read_sql(
         results = rel.fetchall()
 
         benchmarks = [dict(zip(columns, r)) for r in results]
-        context = Context()
+        context = {}
         for bm in benchmarks:
             context.update(bm.pop("context", {}))
 
diff --git a/tests/test_context.py b/tests/test_context.py
deleted file mode 100644
index 54494976..00000000
--- a/tests/test_context.py
+++ /dev/null
@@ -1,108 +0,0 @@
-import pytest
-
-from nnbench.context import Context, CPUInfo, GitEnvironmentInfo, PythonInfo
-
-
-def test_python_package_info() -> None:
-    p = PythonInfo("pre-commit", "pyyaml")()
-    res = p["python"]
-
-    deps = res["dependencies"]
-    for v in deps.values():
-        assert v != ""
-
-    # for a bogus package, it should not fail but produce an empty string.
-    p = PythonInfo("asdfghjkl")()
-    res = p["python"]
-
-    deps = res["dependencies"]
-    for v in deps.values():
-        assert v == ""
-
-
-def test_git_info_provider() -> None:
-    g = GitEnvironmentInfo()()
-    res = g["git"]
-    # tag might not be available in a shallow checkout in CI,
-    # but commit, provider and repo are.
-    assert res["commit"] != ""
-    assert res["provider"] == "github.com"
-    assert res["repository"] == "aai-institute/nnbench"
-
-
-def test_cpu_info_provider() -> None:
-    c = CPUInfo()()
-    res = c["cpu"]
-
-    # just check that the most important fields are populated across
-    # the popular CPU architectures.
-    assert res["architecture"] != ""
-    assert res["system"] != ""
-    assert res["frequency"] >= 0
-    assert res["num_cpus"] > 0
-    assert res["total_memory"] > 0
-
-
-def test_flatten_nested_dictionary():
-    nested_ctx = Context({"a": 1, "b": {"c": 2, "d": {"e": 3}}})
-    flattened = nested_ctx.flatten()
-    assert flattened == {"a": 1, "b.c": 2, "b.d.e": 3}
-
-
-def test_unflatten_dictionary():
-    flat_data = {"a": 1, "b.c": 2, "b.d.e": 3}
-    unflattened = Context.unflatten(flat_data)
-    assert unflattened == {"a": 1, "b": {"c": 2, "d": {"e": 3}}}
-
-
-def test_context_keys():
-    ctx = Context({"a": 1, "b": {"c": 2}})
-    expected_keys = {"a", "b.c"}
-    assert set(ctx.keys()) == expected_keys
-
-
-def test_context_values():
-    ctx = Context({"a": 1, "b": {"c": 2}})
-    expected_values = {1, 2}
-    assert set(ctx.values()) == expected_values
-
-
-def test_context_items():
-    ctx = Context({"a": 1, "b": {"c": 2}})
-    expected_items = {("a", 1), ("b.c", 2)}
-    assert set(ctx.items()) == expected_items
-
-
-def test_context_update_with_key_collision():
-    ctx = Context({"a": 1, "b": 2})
-    with pytest.raises(ValueError, match=r".*multiple values for context.*"):
-        ctx.update(Context.make({"a": 3, "c": 4}))
-
-
-def test_context_update_duplicate_with_replace():
-    ctx = Context({"a": 1, "b": 2})
-    ctx.update(Context.make({"a": 3, "c": 4}), replace=True)
-    expected_dict = {"a": 3, "b": 2, "c": 4}
-    assert ctx._data == expected_dict
-
-
-def test_update_with_context():
-    ctx = Context({"a": 1, "b": 2})
-    ctx.update(Context.make({"c": 4}))
-    expected_dict = {"a": 1, "b": 2, "c": 4}
-    assert ctx._data == expected_dict
-
-
-def test_add_with_provider():
-    ctx = Context({"a": 1, "b": 2})
-    ctx.add(lambda: {"c": 4})
-    expected_dict = {"a": 1, "b": 2, "c": 4}
-    assert ctx._data == expected_dict
-
-
-def test_update_with_context_instance():
-    ctx1 = Context({"a": 1, "b": {"c": 2}})
-    ctx2 = Context({"d": 4})
-    ctx1.update(ctx2)
-    expected_dict = {"a": 1, "b": {"c": 2}, "d": 4}
-    assert ctx1._data == expected_dict
diff --git a/tests/test_fileio.py b/tests/test_fileio.py
index a03d4f25..16988d5a 100644
--- a/tests/test_fileio.py
+++ b/tests/test_fileio.py
@@ -4,7 +4,6 @@
 
 import pytest
 
-from nnbench.context import Context
 from nnbench.reporter.file import FileIO
 from nnbench.types import BenchmarkRecord
 
@@ -20,7 +19,7 @@ def test_fileio_writes_no_compression_inline(
     f = FileIO()
 
     rec = BenchmarkRecord(
-        context=Context.make({"a": "b", "s": 1, "b.c": 1.0}),
+        context={"a": "b", "s": 1, "b.c": 1.0},
         benchmarks=[{"name": "foo", "value": 1}, {"name": "bar", "value": 2}],
     )
     file = tmp_path / f"record.{ext}"