Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support to 1.12 #12

Open
JackWisdom opened this issue Feb 18, 2018 · 1 comment
Open

Please support to 1.12 #12

JackWisdom opened this issue Feb 18, 2018 · 1 comment

Comments

@JackWisdom
Copy link

in spigot 1.12
PacketPlayOutWindowItems
returns List instead of Array
please change your code

public ItemStack[] getItems() {
return handle.getItemListModifier().read(0).toArray(new ItemStack[0]);
}

@kristianvld
Copy link

This project was last updated 4 years ago and currently on Minecraft version 1.7.2.

A fork of this project seems to still be actively developed and is currently up to version 1.12.2:
https://github.com/dmulloy2/PacketWrapper

Also when suggesting line edits on GitHub, you can actually go edit the files your self, make a commit on a forked branch and create and issue requesting to merge in your changes. Makes it easier to keep track of context and see what the edits would imply and removes any confusion, instead of having to manually find the file you are talking about look through the code to find where in the file you suggest the edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants