Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First box background focused by default #32

Open
poppinjay13 opened this issue Mar 25, 2021 · 2 comments
Open

First box background focused by default #32

poppinjay13 opened this issue Mar 25, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@poppinjay13
Copy link

First of all, great job with the library, I love it.
However, I've noted that the first box's background gives the impression of being focused by default which is misleading for instances where there is another view (Edittext) in focus at the time. Users thinking the pinview is focused type out the pin in the wrong view. Is it possible to only have the focused background either once a user clicks on it or once it is focused on?

@aabhasr1
Copy link
Owner

I agree with this observation.
I'll try to make the changes as soon as possible. Meanwhile, if you have done those changes at your end just Raise a PR and i will merge it.

@poppinjay13
Copy link
Author

Unfortunately, I'm not as familiar with Kotlin as I work with Java. I had tried to make the update myself but it proved a bit complicated so I opened the issue. It's not urgent but I'll watch the repo for the next update.

@aabhasr1 aabhasr1 self-assigned this Mar 29, 2021
@aabhasr1 aabhasr1 added the enhancement New feature or request label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants