Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send contracts and messages via HTTP rather than the file system #1252

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

JamesHinshelwood
Copy link

Previously, requests would contain a path to a file for:

  • Scilla contracts
  • Init data JSON
  • Message JSON

Instead, we send these directly in the message. The maximum size of a Scilla contract is ~75KB and the maximum size of init data and messages is ~135KB.

I've also deleted two utilities that we aren't (yet) using in ZQ2, so that I don't have to spend time supporting the new request format for them.

Previously, requests would contain a path to a file for:
* Scilla contracts
* Init data JSON
* Message JSON

Instead, we send these directly in the message. The maximum size
of a Scilla contract is ~75KB and the maximum size of init data
and messages is ~135KB.

I've also deleted two utilities that we aren't (yet) using in ZQ2,
so that I don't have to spend time supporting the new request
format for them.
Copy link
Contributor

@mauromedda mauromedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesHinshelwood JamesHinshelwood merged commit a5a81f7 into main-zq2 Apr 16, 2024
1 check passed
@JamesHinshelwood JamesHinshelwood deleted the zq2-strings branch April 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants