From 6ab0c897aa25ce250c59fed3d77fc7d24a28a720 Mon Sep 17 00:00:00 2001
From: Ziktofel <ziktofel@gmail.com>
Date: Wed, 22 May 2024 22:24:52 +0200
Subject: [PATCH] Fix broken Nova Plasma rifle on death effect

---
 .../Base.SC2Data/GameData/BehaviorData.xml    | 24 ++++++++++++
 .../Base.SC2Data/GameData/UnitData.xml        | 39 +++++++++++++++++++
 2 files changed, 63 insertions(+)

diff --git a/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/BehaviorData.xml b/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/BehaviorData.xml
index 913bb381e..8aa6f7092 100644
--- a/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/BehaviorData.xml
+++ b/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/BehaviorData.xml
@@ -6788,4 +6788,28 @@
         <EditorCategories value="AbilityorEffectType:Units"/>
         <Duration value="0.5"/>
     </CBehaviorBuff>
+    <CBehaviorBuff id="AP_NovaWeaponPlasmaKill">
+        <BehaviorFlags index="Permanent" value="1"/>
+        <BehaviorFlags index="EnabledWhileDead" value="1"/>
+        <InfoIcon value="Assets\Textures\btn-upgrade-nova-equipment-plasmagun.dds"/>
+        <EditorCategories value="AbilityorEffectType:Units,Race:Terran"/>
+        <Duration value="1"/>
+        <DamageResponse Chance="1" Fatal="1" Handled="AP_NovaPlasmaPuddle"/>
+    </CBehaviorBuff>
+    <CBehaviorBuff id="AP_NovaWeaponPlasmaKillSmall">
+        <BehaviorFlags index="Permanent" value="1"/>
+        <BehaviorFlags index="EnabledWhileDead" value="1"/>
+        <InfoIcon value="Assets\Textures\btn-upgrade-nova-equipment-plasmagun.dds"/>
+        <EditorCategories value="AbilityorEffectType:Units,Race:Terran"/>
+        <Duration value="1"/>
+        <DamageResponse Chance="1" Fatal="1" Handled="AP_NovaPlasmaPuddleSmall"/>
+    </CBehaviorBuff>
+    <CBehaviorBuff id="AP_NovaWeaponPlasmaKillLarge">
+        <BehaviorFlags index="Permanent" value="1"/>
+        <BehaviorFlags index="EnabledWhileDead" value="1"/>
+        <InfoIcon value="Assets\Textures\btn-upgrade-nova-equipment-plasmagun.dds"/>
+        <EditorCategories value="AbilityorEffectType:Units,Race:Terran"/>
+        <Duration value="1"/>
+        <DamageResponse Chance="1" Fatal="1" Handled="AP_NovaPlasmaPuddleLarge"/>
+    </CBehaviorBuff>
 </Catalog>
diff --git a/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/UnitData.xml b/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/UnitData.xml
index c665e9875..fd26890a3 100644
--- a/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/UnitData.xml
+++ b/Mods/ArchipelagoPlayer.SC2Mod/Base.SC2Data/GameData/UnitData.xml
@@ -10855,6 +10855,26 @@
         <Race value="Terr"/>
         <EditorCategories value="ObjectType:Projectile,ObjectFamily:Campaign"/>
     </CUnit>
+    <CUnit id="AP_NovaPlasmaPuddle">
+        <Race value="Terr"/>
+        <FlagArray index="Uncommandable" value="1"/>
+        <FlagArray index="Unselectable" value="1"/>
+        <FlagArray index="Untargetable" value="1"/>
+        <FlagArray index="Uncursorable" value="1"/>
+        <FlagArray index="KillCredit" value="0"/>
+        <FlagArray index="Invulnerable" value="1"/>
+        <FogVisibility value="Snapshot"/>
+        <Response value="Nothing"/>
+        <LifeStart value="10"/>
+        <LifeMax value="10"/>
+        <StationaryTurningRate value="0"/>
+        <TurningRate value="0"/>
+        <Height value="-0.2"/>
+        <BehaviorArray Link="NovaPlasmaPuddle"/>
+        <MinimapRadius value="0"/>
+        <EditorCategories value="ObjectType:Unit,ObjectFamily:Campaign"/>
+        <Fidget DelayMax="0" DelayMin="0"/>
+    </CUnit>
     <CUnit id="AP_NovaPlasmaPuddleSmall">
         <Race value="Terr"/>
         <FlagArray index="Uncommandable" value="1"/>
@@ -10874,6 +10894,25 @@
         <EditorCategories value="ObjectType:Unit,ObjectFamily:Campaign"/>
         <Fidget DelayMax="0" DelayMin="0"/>
     </CUnit>
+    <CUnit id="AP_NovaPlasmaPuddleLarge">
+        <Race value="Terr"/>
+        <FlagArray index="Uncommandable" value="1"/>
+        <FlagArray index="Unselectable" value="1"/>
+        <FlagArray index="Untargetable" value="1"/>
+        <FlagArray index="Uncursorable" value="1"/>
+        <FlagArray index="KillCredit" value="0"/>
+        <FlagArray index="Invulnerable" value="1"/>
+        <FogVisibility value="Snapshot"/>
+        <Response value="Nothing"/>
+        <LifeStart value="10"/>
+        <LifeMax value="10"/>
+        <StationaryTurningRate value="0"/>
+        <TurningRate value="0"/>
+        <Height value="-0.2"/>
+        <MinimapRadius value="0"/>
+        <EditorCategories value="ObjectType:Unit,ObjectFamily:Campaign"/>
+        <Fidget DelayMax="0" DelayMin="0"/>
+    </CUnit>
     <CUnit id="AP_NovaWeaponPlasmaBlastNewLaunchMissile" parent="WizSimpleMissile" abil="NovaWeaponPlasmaBlastNew">
         <Race value="Terr"/>
         <EditorCategories value="ObjectType:Projectile,ObjectFamily:Campaign"/>