Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(state): Refactor the naming of note commitment subtrees #7855

Merged
merged 4 commits into from
Oct 30, 2023

Rename `Root` to `SubtreeRoot`

a278777
Select commit
Loading
Failed to load commit list.
Merged

change(state): Refactor the naming of note commitment subtrees #7855

Rename `Root` to `SubtreeRoot`
a278777
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Oct 30, 2023 in 0s

The pull request embarked with main (d0e5b2f) is mergeable

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • #review-threads-unresolved=0 [🛡 GitHub branch protection]
  • base=main
  • any of [🛡 GitHub branch protection]:
    • check-success=Rustfmt
    • check-neutral=Rustfmt
    • check-skipped=Rustfmt
  • any of [🛡 GitHub branch protection]:
    • check-success=mergefreeze
    • check-neutral=mergefreeze
    • check-skipped=mergefreeze
  • any of [🛡 GitHub branch protection]:
    • check-success=Clippy
    • check-neutral=Clippy
    • check-skipped=Clippy
  • any of [🛡 GitHub branch protection]:
    • check-success=Test with fake activation heights
    • check-neutral=Test with fake activation heights
    • check-skipped=Test with fake activation heights
  • any of [🛡 GitHub branch protection]:
    • check-success=Test all
    • check-neutral=Test all
    • check-skipped=Test all
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml bans
    • check-neutral=Check deny.toml bans
    • check-skipped=Check deny.toml bans
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml bans --all-features
    • check-neutral=Check deny.toml bans --all-features
    • check-skipped=Check deny.toml bans --all-features
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml sources
    • check-neutral=Check deny.toml sources
    • check-skipped=Check deny.toml sources
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml sources --all-features
    • check-neutral=Check deny.toml sources --all-features
    • check-skipped=Check deny.toml sources --all-features
  • any of [🛡 GitHub branch protection]:
    • check-success=Check Cargo.lock is up to date
    • check-neutral=Check Cargo.lock is up to date
    • check-skipped=Check Cargo.lock is up to date
  • any of [🛡 GitHub branch protection]:
    • check-success=Install zebrad from lockfile without cache on ubuntu-latest
    • check-neutral=Install zebrad from lockfile without cache on ubuntu-latest
    • check-skipped=Install zebrad from lockfile without cache on ubuntu-latest
  • any of [🛡 GitHub branch protection]:
    • check-success=Test checkpoint sync from empty state
    • check-neutral=Test checkpoint sync from empty state
    • check-skipped=Test checkpoint sync from empty state
  • any of [🛡 GitHub branch protection]:
    • check-success=Zebra checkpoint update / Run sync-past-checkpoint test
    • check-neutral=Zebra checkpoint update / Run sync-past-checkpoint test
    • check-skipped=Zebra checkpoint update / Run sync-past-checkpoint test
  • any of [🛡 GitHub branch protection]:
    • check-success=Zebra tip JSON-RPC / Run fully-synced-rpc test
    • check-neutral=Zebra tip JSON-RPC / Run fully-synced-rpc test
    • check-skipped=Zebra tip JSON-RPC / Run fully-synced-rpc test
  • any of [🛡 GitHub branch protection]:
    • check-success=Build tower-fallback crate
    • check-neutral=Build tower-fallback crate
    • check-skipped=Build tower-fallback crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-chain crate
    • check-neutral=Build zebra-chain crate
    • check-skipped=Build zebra-chain crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-consensus crate
    • check-neutral=Build zebra-consensus crate
    • check-skipped=Build zebra-consensus crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-network crate
    • check-neutral=Build zebra-network crate
    • check-skipped=Build zebra-network crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-node-services crate
    • check-neutral=Build zebra-node-services crate
    • check-skipped=Build zebra-node-services crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-rpc crate
    • check-neutral=Build zebra-rpc crate
    • check-skipped=Build zebra-rpc crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-script crate
    • check-neutral=Build zebra-script crate
    • check-skipped=Build zebra-script crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-state crate
    • check-neutral=Build zebra-state crate
    • check-skipped=Build zebra-state crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-test crate
    • check-neutral=Build zebra-test crate
    • check-skipped=Build zebra-test crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebra-utils crate
    • check-neutral=Build zebra-utils crate
    • check-skipped=Build zebra-utils crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Build zebrad crate
    • check-neutral=Build zebrad crate
    • check-skipped=Build zebrad crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Zebra tip update / Run update-to-tip test
    • check-neutral=Zebra tip update / Run update-to-tip test
    • check-skipped=Zebra tip update / Run update-to-tip test
  • any of [🛡 GitHub branch protection]:
    • check-success=Test beta on ubuntu-latest
    • check-neutral=Test beta on ubuntu-latest
    • check-skipped=Test beta on ubuntu-latest
  • any of [🛡 GitHub branch protection]:
    • check-success=Test stable on ubuntu-latest
    • check-neutral=Test stable on ubuntu-latest
    • check-skipped=Test stable on ubuntu-latest
  • any of [🛡 GitHub branch protection]:
    • check-success=Build CI Docker / Build images
    • check-neutral=Build CI Docker / Build images
    • check-skipped=Build CI Docker / Build images
  • any of [🛡 GitHub branch protection]:
    • check-success=Build lightwalletd Docker
    • check-neutral=Build lightwalletd Docker
    • check-skipped=Build lightwalletd Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=submit block / Run submit-block test
    • check-neutral=submit block / Run submit-block test
    • check-skipped=submit block / Run submit-block test
  • any of [🛡 GitHub branch protection]:
    • check-success=get block template / Run get-block-template test
    • check-neutral=get block template / Run get-block-template test
    • check-skipped=get block template / Run get-block-template test
  • any of [🛡 GitHub branch protection]:
    • check-success=Check for unused dependencies
    • check-neutral=Check for unused dependencies
    • check-skipped=Check for unused dependencies
  • any of [🛡 GitHub branch protection]:
    • check-success=Check if cached state disks exist for Mainnet / Check if cached state disks exist
    • check-neutral=Check if cached state disks exist for Mainnet / Check if cached state disks exist
    • check-skipped=Check if cached state disks exist for Mainnet / Check if cached state disks exist
  • any of [🛡 GitHub branch protection]:
    • check-success=Check crates matrix
    • check-neutral=Check crates matrix
    • check-skipped=Check crates matrix
  • any of [🛡 GitHub branch protection]:
    • check-success=Generate crates matrix
    • check-neutral=Generate crates matrix
    • check-skipped=Generate crates matrix
  • any of [🛡 GitHub branch protection]:
    • check-success=Build tower-batch-control crate
    • check-neutral=Build tower-batch-control crate
    • check-skipped=Build tower-batch-control crate
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml bans --features default-release-binaries
    • check-neutral=Check deny.toml bans --features default-release-binaries
    • check-skipped=Check deny.toml bans --features default-release-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=Check deny.toml sources --features default-release-binaries
    • check-neutral=Check deny.toml sources --features default-release-binaries
    • check-skipped=Check deny.toml sources --features default-release-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=Check crate release dry run
    • check-neutral=Check crate release dry run
    • check-skipped=Check crate release dry run
  • any of [🛡 GitHub branch protection]:
    • check-success=Build CD Docker / Build images
    • check-neutral=Build CD Docker / Build images
    • check-skipped=Build CD Docker / Build images
  • any of [🛡 GitHub branch protection]:
    • check-success=Test integration with lightwalletd
    • check-neutral=Test integration with lightwalletd
    • check-skipped=Test integration with lightwalletd
  • any of [🛡 GitHub branch protection]:
    • check-success=lightwalletd GRPC tests / Run lwd-grpc-wallet test
    • check-neutral=lightwalletd GRPC tests / Run lwd-grpc-wallet test
    • check-skipped=lightwalletd GRPC tests / Run lwd-grpc-wallet test
  • any of [🛡 GitHub branch protection]:
    • check-success=lightwalletd tip send / Run lwd-send-transactions test
    • check-neutral=lightwalletd tip send / Run lwd-send-transactions test
    • check-skipped=lightwalletd tip send / Run lwd-send-transactions test
  • any of [🛡 GitHub branch protection]:
    • check-success=Build and Deploy Zebra Book Docs
    • check-neutral=Build and Deploy Zebra Book Docs
    • check-skipped=Build and Deploy Zebra Book Docs
  • any of [🛡 GitHub branch protection]:
    • check-success=Build and Deploy Zebra External Docs
    • check-neutral=Build and Deploy Zebra External Docs
    • check-skipped=Build and Deploy Zebra External Docs
  • any of [🛡 GitHub branch protection]:
    • check-success=Build and Deploy Zebra Internal Docs
    • check-neutral=Build and Deploy Zebra Internal Docs
    • check-skipped=Build and Deploy Zebra Internal Docs
  • any of [🛡 GitHub branch protection]:
    • check-success=lightwalletd tip update / Run lwd-update-sync test
    • check-neutral=lightwalletd tip update / Run lwd-update-sync test
    • check-skipped=lightwalletd tip update / Run lwd-update-sync test
  • any of [🛡 GitHub branch protection]:
    • check-success=Generate checkpoints mainnet / Run checkpoints-mainnet test
    • check-neutral=Generate checkpoints mainnet / Run checkpoints-mainnet test
    • check-skipped=Generate checkpoints mainnet / Run checkpoints-mainnet test
  • any of [🛡 GitHub branch protection]:
    • check-success=Test CD custom Docker config file / Test custom-conf in Docker
    • check-neutral=Test CD custom Docker config file / Test custom-conf in Docker
    • check-skipped=Test CD custom Docker config file / Test custom-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=Test CD default Docker config file / Test default-conf in Docker
    • check-neutral=Test CD default Docker config file / Test default-conf in Docker
    • check-skipped=Test CD default Docker config file / Test default-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=Test CI custom Docker config file / Test custom-conf in Docker
    • check-neutral=Test CI custom Docker config file / Test custom-conf in Docker
    • check-skipped=Test CI custom Docker config file / Test custom-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=Test CI default Docker config file / Test default-conf in Docker
    • check-neutral=Test CI default Docker config file / Test default-conf in Docker
    • check-skipped=Test CI default Docker config file / Test default-conf in Docker
  • any of [🛡 GitHub branch protection]:
    • check-success=Test stable on macos-latest
    • check-neutral=Test stable on macos-latest
    • check-skipped=Test stable on macos-latest

Check-runs and statuses of the embarked pull request #7879:

Deploy ${{ matrix.network }} nodesdetails
Deploy single ${{ inputs.network }} instancedetails
Generate checkpoints mainnet / Create ${{ inputs.test_id }} cached state imagedetails
Open or update issues for OS integration failuresdetails
Open or update issues for building crates individually failuresdetails
Open or update issues for main branch failuresdetails
Open or update issues for main branch failuresdetails
Open or update issues for release crates failuresdetails
Open or update issues for release failuresdetails
Versioningdetails
Zebra checkpointdetails
Zebra checkpoint update / Create ${{ inputs.test_id }} cached state imagedetails
Zebra tipdetails
Zebra tip JSON-RPC / Create ${{ inputs.test_id }} cached state imagedetails
Zebra tip on testnetdetails
actionlintdetails
get block template / Create ${{ inputs.test_id }} cached state imagedetails
lightwalletd GRPC tests / Create ${{ inputs.test_id }} cached state imagedetails
lightwalletd tipdetails
lightwalletd tip send / Create ${{ inputs.test_id }} cached state imagedetails
submit block / Create ${{ inputs.test_id }} cached state imagedetails
Build CD Docker / Build imagesdetails
Build CI Docker / Build imagesdetails
Build CI Docker / Build imagesdetails
Build and Deploy Zebra Book Docsdetails
Build and Deploy Zebra External Docsdetails
Build and Deploy Zebra Internal Docsdetails
Build lightwalletd Dockerdetails
Build lightwalletd Dockerdetails
Build tower-batch-control cratedetails
Build tower-fallback cratedetails
Build zebra-chain cratedetails
Build zebra-consensus cratedetails
Build zebra-network cratedetails
Build zebra-node-services cratedetails
Build zebra-rpc cratedetails
Build zebra-script cratedetails
Build zebra-state cratedetails
Build zebra-test cratedetails
Build zebra-utils cratedetails
Build zebrad cratedetails
Check Cargo.lock is up to datedetails
Check crate release dry rundetails
Check crates matrixdetails
Check deny.toml bansdetails
Check deny.toml bans --all-featuresdetails
Check deny.toml bans --features default-release-binariesdetails
Check deny.toml sourcesdetails
Check deny.toml sources --all-featuresdetails
Check deny.toml sources --features default-release-binariesdetails
Check for unused dependenciesdetails
Check if cached state disks exist for Mainnet / Check if cached state disks existdetails
Check if cached state disks exist for testnet / Check if cached state disks existdetails
Checks changed-filesdetails
Clippydetails
Clippydetails
Generate checkpoints mainnet / Delete checkpoints-mainnet instancedetails
Generate checkpoints mainnet / Run checkpoints-mainnet testdetails
Generate checkpoints testnet / Create checkpoints-testnet cached state imagedetails
Generate checkpoints testnet / Delete checkpoints-testnet instancedetails
Generate checkpoints testnet / Run checkpoints-testnet testdetails
Generate crates matrixdetails
Install zebrad from lockfile without cache on ubuntu-latestdetails
Rustfmtdetails
Rustfmtdetails
Test CD custom Docker config file / Test custom-conf in Dockerdetails
Test CD default Docker config file / Test default-conf in Dockerdetails
Test CD testnet Docker config file / Test testnet-conf in Dockerdetails
Test CI custom Docker config file / Test custom-conf in Dockerdetails
Test CI default Docker config file / Test default-conf in Dockerdetails
Test CI testnet Docker config file / Test testnet-conf in Dockerdetails
Test alldetails
Test beta on ubuntu-latestdetails
Test checkpoint sync from empty statedetails
Test integration with lightwalletddetails
Test stable on macos-latestdetails
Test stable on ubuntu-latestdetails
Test with fake activation heightsdetails
Zebra checkpoint update / Delete sync-past-checkpoint instancedetails
Zebra checkpoint update / Run sync-past-checkpoint testdetails
Zebra tip JSON-RPC / Delete fully-synced-rpc instancedetails
Zebra tip JSON-RPC / Run fully-synced-rpc testdetails
Zebra tip update / Create update-to-tip cached state imagedetails
Zebra tip update / Delete update-to-tip instancedetails
Zebra tip update / Run update-to-tip testdetails
codespelldetails
codespell — reviewdog [codespell] reportdetails
get block template / Delete get-block-template instancedetails
get block template / Run get-block-template testdetails
lightwalletd GRPC tests / Delete lwd-grpc-wallet instancedetails
lightwalletd GRPC tests / Run lwd-grpc-wallet testdetails
lightwalletd tip send / Delete lwd-send-transactions instancedetails
lightwalletd tip send / Run lwd-send-transactions testdetails
lightwalletd tip update / Create lwd-update-sync cached state imagedetails
lightwalletd tip update / Delete lwd-update-sync instancedetails
lightwalletd tip update / Run lwd-update-sync testdetails
mergefreezeOk to mergedetails
submit block / Delete submit-block instancedetails
submit block / Run submit-block testdetails
update_release_draftdetails
update_release_draftdetails