Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(consensus): Remove Sprout and Sapling parameter download task and debug_skip_preload config #7844

Merged
merged 9 commits into from
Oct 27, 2023
Merged

change(consensus): Remove Sprout and Sapling parameter download task and debug_skip_preload config #7844

merged 9 commits into from
Oct 27, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Oct 26, 2023 •
edited
Loading

Motivation

This PR removes the now-unused Sprout/Sapling parameter download task and debug_skip_preload_parameter config field.

Closes #7810.

Solution

  • Remove groth16_download_handle from BackgroundTaskHandles and zebra_consensus::init()
  • Update calls to zebra_consensus::init() from start command and tests
  • Convert consensus config to/from InnerConfig that accepts but ignores debug_skip_preload_parameter from old configs

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@arya2 arya2 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup P-Medium ⚡ I-usability Zebra is hard to understand or use C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 26, 2023
@arya2 arya2 self-assigned this Oct 26, 2023
@arya2 arya2 requested review from a team as code owners October 26, 2023 16:45
@arya2 arya2 requested review from teor2345 and removed request for a team October 26, 2023 16:45
@github-actions github-actions bot added C-bug Category: This is a bug extra-reviews This PR needs at least 2 reviews to merge labels Oct 26, 2023
@teor2345 teor2345 removed C-enhancement Category: This is an improvement C-bug Category: This is a bug labels Oct 26, 2023
teor2345
teor2345 suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but changing the default value of a config is a blocker.

@github-actions github-actions bot added the C-bug Category: This is a bug label Oct 26, 2023
@arya2 arya2 requested a review from teor2345 October 26, 2023 23:20
teor2345
teor2345 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good now

@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Oct 27, 2023
mergify bot added a commit that referenced this pull request Oct 27, 2023
@mergify
Merge of #7844
eb3d899
@mergify mergify bot mentioned this pull request Oct 27, 2023
Closed
@mergify mergify bot merged commit 0a3790b into main Oct 27, 2023
159 checks passed
@mergify mergify bot deleted the rm-param-download branch October 27, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@arya2 arya2

Labels
A-consensus Area: Consensus rule updates C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sprout and sapling parameter downloads and preload config
2 participants
@arya2 @teor2345