-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking: Block Explorer support #8435
Comments
Hey @mpguerra , thank you for putting all this together. I think we need a ticket to install (fork if changes are needed) locally the https://github.com/nighthawk-apps/zcash-explorer |
This is now #8456 |
@mpguerra could you add the resources you used to compose the lists of the RPCs? |
https://gist.github.com/oxarbitrage/a56f7e6b9b198ba70150a3afb2ffc949 |
@conradoplg I noticed you tried running https://github.com/nighthawk-apps/zcash-explorer locally. It should use this tool https://github.com/nighthawk-apps/zcashex as a middleware between the explorer and full node. It looks like it should be sufficient to implement the RPCs used in this file https://github.com/nighthawk-apps/zcashex/blob/main/lib/zcashex.ex to have a full support of the block explorer. |
(So I think you don't need to list the RPCs manually.) |
I extracted the RPCs from https://github.com/nighthawk-apps/zcashex/blob/main/lib/zcashex.ex:
Some of the RPCs are already listed in the PR description, but these are missing:
|
Here's a list of RPCs from Conrado which splits them according to what Zebra does and doesn't implement: Zebra has: Zebra doesn't have: |
@oxarbitrage Is the elastic search feature of Zebra oriented to support Zcash Block Explorer uniquely or does it go beyond the scope of this tracking issue? |
The elastic search feature was NOT meant to support a Zcash block explorer, it was just a hack sprint experiment that @oxarbitrage wanted to try out. It's our intention to implement the RPC methods in this tracking issue in order to support a block explorer such as Nighthawk's Zcash Explorer. However, we are not aware of anyone that is currently maintaining this block explorer, nor do we intend to take over maintenance of it. Ideally, we would collaborate with some existing teams that are running zcash block explorers and help them to replace their zcashd instance with zebra by implementing their required RPC methods. EDIT: If someone has plans to take over development of https://github.com/nighthawk-apps/zcash-explorer we'd be interested in providing some feedback on some incompatibilities with JSON-RPC standards, @upbqdn has more details on this. |
Motivation
This is the tracking issue to outline the work necessary in order for zebra to support block explorers.
Zcash Block explorers
We're initially implementing support for https://github.com/nighthawk-apps/zcash-explorer.
RPC Methods
Using the Zcash Block Explorer from above as an example, these are the following RPC methods that would need to be implemented in zebra:
getblockhashes
RPC method #8436getmempoolinfo
RPC method #8437getnetworksolps
RPC method #8438getaddressdeltas
RPC method #8440z_listunifiedreceivers
RPC method #8441getblockheader
RPC method #8442z_validatepaymentdisclosure
RPC method #8443validateaddress
RPC method #8444z_validateaddress
RPC method #8445The following RPC methods should also be updated to support all of the required query and result fields:
getblock
RPC method #8446getrawmempool
RPC method #8447getinfo
RPC method #8448getblockchaininfo
RPC method #8449getpeerinfo
RPC method #8450getrawtransaction
RPC method #8451getaddressbalance
RPC method #8452Other
error
field to RPC responses #8672The text was updated successfully, but these errors were encountered: