Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintentional fall through? #18

Open
barrya-acn opened this issue Mar 16, 2017 · 0 comments
Open

Unintentional fall through? #18

barrya-acn opened this issue Mar 16, 2017 · 0 comments

Comments

@barrya-acn
Copy link
Contributor

In zconnection.c, zconnection_recv_raw(...) line 143 there is a default switch case that unlocks the connection mutex. From the comment I suspect the intention is to drop the packet and return from the method. However this doesn't happen, and further down the same method the mutex is unlocked again. Since unlocking a mutex twice is undefined behavior it reinforces the probability that there is an issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants