Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YunoHost tile is not displayed when the app is installed on root path #285

Closed
yunohost-bot opened this issue Mar 22, 2016 · 11 comments
Closed
Labels
🚪 SSO 👾 bug Something isn't working
Milestone

Comments

@yunohost-bot
Copy link

Original Redmine Issue: 285

Author Name: opi


/ynhpanel.js can't be served

Reported by emile. Dirty fix here https://pad.sebian.fr/p/yuno_icon_fail

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: opi


Can't reproduce in unstable version, but need more tests before closing this issue.

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: opi


Able to reproduce, so this issue is still open :/

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: moul


I reproduce this bug with Duniter app which can only be installed on root path for now.

I also encounter an issue with Gogs and Jirafeau app which are not installed on root path and which do not display the tile.

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: moul


I also reproduce on app installed on non main domain.

@yunohost-bot
Copy link
Author

Properties Change

Author: moul

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: JimboJoe


The issue is systematic when an app is installed on root path and that path is set in unprotected_urls. It is caused by the unprotected_urls processing in access.lua that passes the URL before having the chance to process specific files (including YunoHost tile).
Proposed fix: YunoHost/SSOwat#71

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: alexAubin


Thanks a lot for the PR !

@yunohost-bot
Copy link
Author

Properties Change

Author: alexAubin

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: JimboJoe


The proposed fix is still not enough.
There are different causes for this problem:

  • the previous proposed PR on SSOwat is still needed to serve the needed files for unprotected_urls

  • this PR on yunohost_panel.conf.inc is also needed to fix the problem for apps serving non text/html pages (like Jirafeau), or apps for which nginx rules block needed files (like Nextcloud or Duniter)

  • some apps must be "fixed" anyway:

    • apps using proxy_pass, for which we need to prevent upstream from compressing (if it does compress); that prevents the nginx sub_filters to be applied. See this explanation, and as an example the fix on NetData package.

    • Nextcloud prevents the ynhpanel.js file from loading due to CSP nonce rules implemented in version 11 (see this bug)

    • Duniter on almost all /webui pages except log pages (see this bug) for reasons unexplained yet.

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: alexAubin


YunoHost/yunohost#276 has been merged
YunoHost/SSOwat#71 still ongoing

@yunohost-bot
Copy link
Author

Original Redmine Comment

Author: alexAubin

Status Changed: Resolved


YunoHost/SSOwat#71 got merged

I'm closing this ticket because that looks like the only thing we can do on the core side. As said by JimboJoe, some apps will have to be fixed directly because the initial nginx conf is not good (or use stuff like proxy_pass) and will need to be tweaked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚪 SSO 👾 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants