Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Add dependency on simplejson for Python <2.7 #46

Open
patricklucas opened this issue Oct 20, 2014 · 0 comments · May be fixed by #47
Open

Add dependency on simplejson for Python <2.7 #46

patricklucas opened this issue Oct 20, 2014 · 0 comments · May be fixed by #47
Labels
enhancement

Comments

@patricklucas
Copy link
Contributor

From my comment on #18:

Since pyleus deps msgpack now, and we already dep argparse for python <2.7, I think we should just add a dep on simplejson in the same manner.

We could import it in the newly-added compat.py so we don't have to litter try: import simplejson as json everywhere.
@patricklucas patricklucas self-assigned this Oct 20, 2014
patricklucas pushed a commit to patricklucas/pyleus that referenced this issue Oct 20, 2014
Depend on simplejson for Python < 2.7
1e6ac7d 
This adds a dependency on simplejson for Python < 2.7 and moves the
stanza to import the appropriate json module into pyleus.compat.

Closes Yelp#46
@patricklucas patricklucas linked a pull request Oct 20, 2014 that will close this issue
Open
@patricklucas patricklucas removed their assignment May 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depend on simplejson for Python < 2.7 patricklucas/pyleus
2 participants
@patricklucas @poros