-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRC Alert #319
Open
amoennin
wants to merge
27
commits into
Yelp:master
Choose a base branch
from
amoennin:irc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
IRC Alert #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRC Alert - preliminary
…eparately, closes connection upon sending message
Removed bg thread, created IRC object in init method, sends message s…
…IRC from alerts.py, changed hash in .pre-commit to avoid strange VersionConflict message about flake8
Moved IRCAlert to ircalert.py, changed mock test and config, removed IRC from alerts.py, changed hash in .pre-commit to avoid strange VersionConflict message about flake8
…] Connection reset by peer' error when a rule is run
…de re. flake8, edit test rule
…ed alert re. irc library version change; edited requirements to accommodate version changes
…equirements.txt and edited setup script accordingly
elastalert/ircalert.py
Outdated
class IRCAlerter(Alerter): | ||
'''Connects to an IRC channel, sends alert, and leaves''' | ||
required_options = frozenset(['irc_server', 'irc_port', 'irc_channel', 'irc_realname']) | ||
getattr(logging, 'DEBUG') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't do anything?
ajaywk7
pushed a commit
to freshdesk/elastalert
that referenced
this pull request
Feb 14, 2023
Support character limit for chatwork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additions include an alerter that connects to an IRC channel, sends a message (alert), and then disconnects. The Python IRC library used here is an older version to accommodate both python 2.6 and 2.7. There is an example rule called "testIRCRule.yaml" which can be used to demonstrate a working alert, once configured. Thanks!