Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate node title error between files #45

Open
krispya opened this issue Oct 10, 2023 · 2 comments
Open

Duplicate node title error between files #45

krispya opened this issue Oct 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@krispya
Copy link

krispya commented Oct 10, 2023

What is the current behavior?

I have two .yarn files that each have a node named 'Start'. It gives the error More than one node is named Start even though it is valid to repeat names between files.

Please provide the steps to reproduce, and if possible a minimal demo of the problem:

Create two .yarn files and name the nodes the same in each.

What is the expected behavior?

I expect to only get this error if two nodes in the same file are named the same. As far as I know, this is expected by spec: https://github.com/YarnSpinnerTool/YarnSpinner/blob/9275277f50a6acbe8438b29596acc8527cf5581a/Documentation/Yarn-Spec.md#title-tag

Please tell us about your environment:

I'm using Yarn in JS.

  • Extension Version: v2.2.128
@krispya krispya added the bug Something isn't working label Oct 10, 2023
@warent
Copy link

warent commented Jun 10, 2024

Anyone planning on fixing this? Maybe I can submit a PR

@warent
Copy link

warent commented Jun 11, 2024

Actually I think this is the correct behavior because of the concept of a yarn project which compiles multiple files into a single context. So basically there just needs to be concept of namespaces / project spaces, or something. Seems like a larger architectural decision beyond me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants