Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect extensionID provided to .NET Install Tool dependency #42

Open
Orange-Panda opened this issue Aug 11, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Orange-Panda
Copy link

What is the current behavior?

When trying to define a dotnet installation path to the .NET Install Tool for Extension Authors dependency using the dotnetAcquisitionExtension.existingDotnetPath setting with the extension id of SecretLab.yarn-spinner is unrecognized.

Please provide the steps to reproduce, and if possible a minimal demo of the problem:

  • In visual studio code user settings add the following:
    • "dotnetAcquisitionExtension.existingDotnetPath": [{ "extensionId": "SecretLab.yarn-spinner", "path": "C:\\Program Files\\dotnet\\dotnet.exe" }]
  • Open any yarn spinner project to activate the Yarn Spinner Extension
    • You may need to restart Visual Studio Code if the extension has already been activated
  • Observe the Output tab for .NET Runtime
    • It will not recognize the provided extensionId for the setting and try to acquire .NET
  • Update the settings extensionId to just yarn-spinner
  • Relaunch Visual Studio Code
  • Open any yarn spinner project to activate the Yarn Spinner Extension
  • Observe the Output tab for .NET Runtime
    • It will recognize the extensionId and load the existing path, however this extensionId is inconsistent with the actual extension id of the yarn spinner extension which is SecretLab.yarn-spinner

What is the expected behavior?

Using the extensionId of SecretLab.yarn-spinner in settings should override the path for the .NET Install Tool instead of yarn-spinner.

Please tell us about your environment:

  • Extension Version: 2.2.119

Other information

Context: This issue was encountered due to .NET acquisition failing. Manually installing .NET and overriding the path for the .NET Install Tool using SecretLab.yarn-spinner will always fail.

I found a stack trace which led me to this line in extension.ts which I noticed the extension id was just yarn-spinner instead ofSecretLab.yarn-spinner.

Possible Solution: I believe this issue can be fixed by changing the call to the .NET Install Tool to use the full extensionId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant