Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Raise Exception in Compile Failure #364

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Nov 4, 2024

Description

This PR raises an exception for errors during compilation. Previously, any exceptions that occurred during the compilation process were caught and printed, but the compilation would continue, which could cause issues downstream if the compilation did not complete as expected. The code has been updated to raise a ValueError after catching an exception, which will rightfully terminate the process and notify the error.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

To verify this change, the following tests were conducted:

1. Compilation Test via CLI

1. Attempt to compile an uncompleted diagram using the CLI.
2. Ensure that compilation fails and raises a `ValueError` with the correct message.

2. Compilation Test via Xircuits Canvas

1. Attempt to compile an uncompleted diagram from the Xircuits Canvas.
2. Verify that the process stops and a `ValueError` is raised, preventing any downstream processes from occurring.

These tests ensure that the compile function now properly halts on exceptions, providing users with clear feedback on compilation issues.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

github-actions bot commented Nov 4, 2024

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/fix-fail-compile-response

@MFA-X-AI MFA-X-AI merged commit 90aef3f into master Nov 4, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/fix-fail-compile-response branch November 4, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant