🐛 Raise Exception in Compile Failure #364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR raises an exception for errors during compilation. Previously, any exceptions that occurred during the compilation process were caught and printed, but the compilation would continue, which could cause issues downstream if the compilation did not complete as expected. The code has been updated to raise a
ValueError
after catching an exception, which will rightfully terminate the process and notify the error.Pull Request Type
Type of Change
Tests
To verify this change, the following tests were conducted:
1. Compilation Test via CLI
2. Compilation Test via Xircuits Canvas
These tests ensure that the compile function now properly halts on exceptions, providing users with clear feedback on compilation issues.
Tested on?