Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_2] migrate curl to lolly #58

Merged
merged 12 commits into from
Aug 18, 2023
Merged

[10_2] migrate curl to lolly #58

merged 12 commits into from
Aug 18, 2023

Conversation

Charonxin
Copy link
Collaborator

No description provided.

@Charonxin
Copy link
Collaborator Author

image

@Charonxin
Copy link
Collaborator Author

I think basic data type can't work well on windows.
Ref:https://learn.microsoft.com/en-us/cpp/cpp/data-type-ranges?view=msvc-170

@Charonxin
Copy link
Collaborator Author

Also, clear comments are necessary to separate the different parts.
comments need improve.

@Charonxin
Copy link
Collaborator Author

Can't support curl for Windows platform.

@Charonxin Charonxin requested a review from da-liii August 16, 2023 06:26
xmake.lua Outdated Show resolved Hide resolved
typedef char QI;
typedef unsigned char QN;
typedef long long DI;
typedef unsigned long long DN;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只针对某一个做判断即可 然后可以用else

xmake.lua Outdated
@@ -72,6 +77,8 @@ target("liblolly") do

set_basename("lolly")

--- dependent packages
add_packages("libcurl")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要筛选一下平台么?为什么?

@Charonxin Charonxin merged commit 04402e1 into main Aug 18, 2023
7 checks passed
@Charonxin Charonxin deleted the charonxin/10_2/Curl branch August 18, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants