Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tm_timer #45

Merged
merged 6 commits into from
Aug 9, 2023
Merged

fix tm_timer #45

merged 6 commits into from
Aug 9, 2023

Conversation

paradisuman
Copy link
Collaborator

While conducting unit tests, I noticed that in the tm_timer functions, the tm_ostream parameter was not being passed by reference. This caused the memory of tm_ostream to be deallocated when the function finished, resulting in unexpected null pointers. Therefore, I changed these parameters to be passed by reference.

@Charonxin
Copy link
Collaborator

Please supplement the test.

@paradisuman
Copy link
Collaborator Author

Please supplement the test.

OK, I'll submit the test later.

@paradisuman
Copy link
Collaborator Author

挂了四个两个是引入了doctest,一个是标准库冲突,还有一个获取时间出现了负值

@da-liii
Copy link
Contributor

da-liii commented Aug 9, 2023

https://github.com/XmacsLabs/lolly/blob/main/System/Classes/tm_timer.hpp#L18-L40

你的错误和上面这些代码有关

@da-liii
Copy link
Contributor

da-liii commented Aug 9, 2023

你需要把上面的关键代码移动到 https://github.com/XmacsLabs/lolly/blob/main/System/config_l1.h.xmake

这样就不需要重复处理这个问题了

@paradisuman
Copy link
Collaborator Author

你需要把上面的关键代码移动到 https://github.com/XmacsLabs/lolly/blob/main/System/config_l1.h.xmake

这样就不需要重复处理这个问题了

好的,我去添加一下xmake

@Charonxin
Copy link
Collaborator

Charonxin commented Aug 9, 2023

@Charonxin
Copy link
Collaborator

代码格式化只能hpp和cpp文件。。。

@Charonxin Charonxin merged commit b2addf7 into XmacsLabs:main Aug 9, 2023
7 checks passed
@da-liii
Copy link
Contributor

da-liii commented Aug 9, 2023

@Charonxin 尽可能不要在别人的分支上做提交,这样做或许会是一种不尊重别人的行为

@Charonxin
Copy link
Collaborator

@Charonxin 尽可能不要在别人的分支上做提交,这样做或许会是一种不尊重别人的行为

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants