re-enable string join strategy improvement #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-liii
reviewed
Jul 9, 2024
| @@ -163,8 +163,12 @@ template <typename T> class lolly_tree_rep : concrete_struct { | |||
| template <typename T> | |||
| inline int | |||
| N (lolly_tree<T> t) { | |||
| CHECK_COMPOUND (t); | |||
There was a problem hiding this comment.
如果这里的更改和字符串无关,建议单独提交一个代码合并请求,描述这个bug,并修复这个bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable string join strategory, and fix behavior of N(tree) caused by layout change