Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19_3] Rename as_hexadecimal to uint32_to_Hex #336

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[19_3] Rename as_hexadecimal to uint32_to_Hex #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lolly/data/numeral.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ as_hexadecimal (int i, int len) {
}

string
as_hexadecimal (uint32_t i) {
uint32_to_Hex (uint32_t i) {
string result;
to_Hex_positive (i, result);
return result;
Expand Down
2 changes: 1 addition & 1 deletion lolly/data/numeral.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ string as_hexadecimal (int i, int length);
* @param i The integer to be converted to a hexadecimal string.
* @return The hexadecimal string representation of the input integer.
*/
string as_hexadecimal (uint32_t i);
string uint32_to_Hex (uint32_t i);

/**
* @brief Converts a binary stream to its hexadecimal represention.
Expand Down
28 changes: 14 additions & 14 deletions tests/lolly/data/numeral_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,26 +177,26 @@ TEST_CASE ("as_hexadecimal fixed") {
SUBCASE ("max") { string_eq (as_hexadecimal (UINT32_MAX, 8), "FFFFFFFF"); }
}

TEST_CASE ("as_hexadecimal") {
TEST_CASE ("uint32_to_Hex") {
SUBCASE ("0-15 (+/-)") {
for (int i= 1; i < 10; i++) {
string_eq (as_hexadecimal (i), as_string (i));
string_eq (as_hexadecimal (i), as_string (i));
string_eq (uint32_to_Hex (i), as_string (i));
string_eq (uint32_to_Hex (i), as_string (i));
}
string_eq (as_hexadecimal (0), "0");
string_eq (as_hexadecimal (10), "A");
string_eq (as_hexadecimal (11), "B");
string_eq (as_hexadecimal (12), "C");
string_eq (as_hexadecimal (13), "D");
string_eq (as_hexadecimal (14), "E");
string_eq (as_hexadecimal (15), "F");
string_eq (uint32_to_Hex (0), "0");
string_eq (uint32_to_Hex (10), "A");
string_eq (uint32_to_Hex (11), "B");
string_eq (uint32_to_Hex (12), "C");
string_eq (uint32_to_Hex (13), "D");
string_eq (uint32_to_Hex (14), "E");
string_eq (uint32_to_Hex (15), "F");
}
SUBCASE ("arbitary") {
string_eq (as_hexadecimal (0x12), "12");
string_eq (as_hexadecimal (0xABC), "ABC");
string_eq (as_hexadecimal (0x80000001), "80000001");
string_eq (uint32_to_Hex (0x12), "12");
string_eq (uint32_to_Hex (0xABC), "ABC");
string_eq (uint32_to_Hex (0x80000001), "80000001");
}
SUBCASE ("max") { string_eq (as_hexadecimal (UINT32_MAX), "FFFFFFFF"); }
SUBCASE ("max") { string_eq (uint32_to_Hex (UINT32_MAX), "FFFFFFFF"); }
}

TEST_CASE ("binary to hexadecimal") {
Expand Down
Loading