Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19_3] Rename as_hexadecimal to uint32_to_Hex #336

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

da-liii
Copy link
Contributor

@da-liii da-liii commented Jun 18, 2024

as_hexadecimal used to receive int as the input, we should not change the semantics in lolly.

That's why I rename the interface.

@da-liii da-liii requested a review from jingkaimori June 18, 2024 14:41
Copy link
Contributor

@jingkaimori jingkaimori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit 81ca96f into main Jun 18, 2024
12 checks passed
@da-liii da-liii deleted the da/19_3/uint32_to_hex branch June 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants