From 64be652b409d904b3837724c7050a23fa92e010a Mon Sep 17 00:00:00 2001
From: Yiheng Wu <36156959+jingkaimori@users.noreply.github.com>
Date: Tue, 11 Jun 2024 09:16:14 +0800
Subject: [PATCH] [8_11] add binary_to_hexadecimal interface

---
 bench/lolly/data/numeral_bench.cpp | 17 +++++++++++++++--
 lolly/data/numeral.cpp             | 12 ++++++++++++
 lolly/data/numeral.hpp             |  8 ++++++++
 tests/lolly/data/numeral_test.cpp  |  8 ++++++++
 4 files changed, 43 insertions(+), 2 deletions(-)

diff --git a/bench/lolly/data/numeral_bench.cpp b/bench/lolly/data/numeral_bench.cpp
index c6a33a4b..09d1dc04 100644
--- a/bench/lolly/data/numeral_bench.cpp
+++ b/bench/lolly/data/numeral_bench.cpp
@@ -5,13 +5,12 @@
  *  \date   2024
  */
 
+#include "file.hpp"
 #include "lolly/data/numeral.hpp"
 #include <nanobench.h>
 
 using namespace lolly::data;
 
-static ankerl::nanobench::Bench bench;
-
 namespace lolly {
 extern void init_tbox ();
 } // namespace lolly
@@ -19,6 +18,7 @@ extern void init_tbox ();
 int
 main () {
   lolly::init_tbox ();
+  ankerl::nanobench::Bench bench;
 #ifdef OS_WASM
   bench.minEpochIterations (2000);
 #else
@@ -37,4 +37,17 @@ main () {
     bench.run ("convert unsigned int to hexadecimal string",
                [&] { as_hexadecimal (hex_number, d); });
   }
+  string                   content= string_load (url_pwd () * "LICENSE");
+  ankerl::nanobench::Bench bench2;
+  bench2.relative (true)
+      .minEpochTime (std::chrono::milliseconds (10))
+      .run ("convert document to hexadecimal string, legacy",
+            [&] {
+              string result;
+              for (int i= 0; i < N (content); i++)
+                result << as_hexadecimal ((unsigned char) content[i], 2);
+            })
+      .run (
+          "convert document to hexadecimal string, using binary_to_hexadecimal",
+          [&] { string result= binary_to_hexadecimal (content); });
 }
diff --git a/lolly/data/numeral.cpp b/lolly/data/numeral.cpp
index 38a8eaf6..619deec7 100644
--- a/lolly/data/numeral.cpp
+++ b/lolly/data/numeral.cpp
@@ -309,5 +309,17 @@ as_hexadecimal (uint32_t i) {
   return result;
 }
 
+string
+binary_to_hexadecimal (string bin) {
+  string res ((int) (N (bin) * 2));
+  int    cur= 0;
+  for (unsigned char ch : bin) {
+    res[cur]    = hex_string[ch >> 4];
+    res[cur + 1]= hex_string[ch & 0x0f];
+    cur+= 2;
+  }
+  return res;
+}
+
 } // namespace data
 } // namespace lolly
diff --git a/lolly/data/numeral.hpp b/lolly/data/numeral.hpp
index 4ba9eea4..223cbc85 100644
--- a/lolly/data/numeral.hpp
+++ b/lolly/data/numeral.hpp
@@ -100,5 +100,13 @@ string as_hexadecimal (int i, int length);
  */
 string as_hexadecimal (uint32_t i);
 
+/**
+ * @brief Converts a binary stream to its hexadecimal represention.
+ *
+ * @param bin The binary data to be converted to a hexadecimal string.
+ * @return The hexadecimal string representation of the input binary.
+ */
+string binary_to_hexadecimal (string bin);
+
 } // namespace data
 } // namespace lolly
diff --git a/tests/lolly/data/numeral_test.cpp b/tests/lolly/data/numeral_test.cpp
index 69d093ef..106844c0 100644
--- a/tests/lolly/data/numeral_test.cpp
+++ b/tests/lolly/data/numeral_test.cpp
@@ -198,3 +198,11 @@ TEST_CASE ("as_hexadecimal") {
   }
   SUBCASE ("max") { string_eq (as_hexadecimal (UINT32_MAX), "FFFFFFFF"); }
 }
+
+TEST_CASE ("binary to hexadecimal") {
+  string header_of_png;
+  header_of_png << "\xff\xd8\xff\xe0";
+  header_of_png << '\x00';
+  header_of_png << "\x10\x4A\x46\x49\x46";
+  string_eq (binary_to_hexadecimal (header_of_png), "FFD8FFE000104A464946");
+}