Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve salt generation #1

Open
Xemdo opened this issue Dec 6, 2020 · 0 comments
Open

Improve salt generation #1

Xemdo opened this issue Dec 6, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@Xemdo
Copy link
Owner

Xemdo commented Dec 6, 2020

Salt generation is currently done by filling up [256]byte slice with random data, and then converting it directly to a string.
Because of this method, each character can only be between 0 and 256 in its value, which is limiting in its security. To improve this, it should be seen if UTF-8 or UTF-16 can be used in the POST data for the salt, and if so a string using that data should be generated instead and sent with the heartbeat.

@Xemdo Xemdo added the enhancement New feature or request label Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant