Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Want to refactor runstrax.py and strax-wrapper.sh #142

Closed
FaroutYLq opened this issue May 20, 2024 · 3 comments
Closed

Want to refactor runstrax.py and strax-wrapper.sh #142

FaroutYLq opened this issue May 20, 2024 · 3 comments
Assignees
@FaroutYLq @minzhong98 @noahhood
Labels
enhancement New feature or request PRIORITY

Comments

@FaroutYLq
Copy link
Collaborator

FaroutYLq commented May 20, 2024 •
edited
Loading

The plan is to use more modern strax context definition to avoid handmade backend. We suspect the length mismatch issue #150 comes from here.
@FaroutYLq FaroutYLq added the enhancement New feature or request label May 20, 2024
@FaroutYLq FaroutYLq self-assigned this May 20, 2024
@FaroutYLq
Copy link
Collaborator Author

if the hypothesis in #150 is correct, the chunk merging bug is nothing to do with the storage magic here. If so we don't have to refactor here.

@dachengx
Copy link
Contributor

MISSION ACCOMPLISHED

@dachengx
Copy link
Contributor

dachengx commented Sep 27, 2024 •
edited
Loading

By

outsource/outsource/workflow/combine.py

Line 40 in 7a2e726

st.merge_per_chunk_storage(
thank to AxFoundation/strax#863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FaroutYLq FaroutYLq

@minzhong98 minzhong98

@noahhood noahhood

Labels
enhancement New feature or request PRIORITY
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dachengx @FaroutYLq @minzhong98 @noahhood