Move typematic rate/delay setting from Kernal init #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been reported in the SMC channel on Discord that some keyboards will not light up the Num Lock LED on boot if you have set keyboard typematic rate/delay in the MENU config. This at least happens with the official Perrix keyboard.
I don't have access to that keyboard to take any data samples, but the issue is likely caused by the Kernal sending the set typematic rate/delay command during keyboard POR or when the SMC is sending the set LEDs command.
The keyboard POR should according to IBM specs take minimum 150 ms and maximum 2.0 s. It might therefore differ a lot how long the POR takes.
To remove the risk that there is interference between the SMC keyboard init and the Kernal init, I suggest that we remove the set typematic rate/delay from Kernal init. We could move it to the keyboard driver and send the setting after receiving the first key code.