feat: 完成排行榜页面的初步开发 #34
Conversation
|
/preview |
|
🪧The website for this PR is deployed at https://open-digger.cn/pull_34/ |
|
看起来移植过来的问题不大，但需要按照 Issue 中的图片需求重新做一下布局，另外搜索框我提了个 PR #35 ，合入以后可以直接使用 SearchInput 组件来做输入和查询的部分。 |
|
master 分支目前切换到了 TypeScript 版本，为了后续更好的开发和维护，新的特性也需要使用 TypeScript 开发，该 PR 需要 rebase 到新版本。 |
收到 |
|
在 #37 更新博客时同时新增了一个 SimpleTable 的组件，这个组件与目前已有的排行榜组件共用底层组件与样式，可以在新的页面中直接使用 |
收到，这个应该根据新的设计稿可以去在页面中增加这个 Table 组件 |
|
目前确定的原型如图，可以按照这个来开发，其中表格组件可以直接使用 SimpleTable 的封装，搜索组件可以直接用 InputSearch 组件。 要点是：
看看有什么问题不，什么时候可以大致出一个布局？ @Bruce-Jay |
Bruce-Jay
force-pushed
the
dev_leaderboard
branch
4 times, most recently
from
e274ea7 to
e0869fa
Compare
Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
* docs: added activity_details Signed-off-by: neilblaze <[email protected]> * docs: add more metrics Signed-off-by: neilblaze <[email protected]> * doc: add latex support and modify some docs. Signed-off-by: frank-zsy <[email protected]> * docs: updated activity Signed-off-by: neilblaze <[email protected]> * merge: commit `421e67f` into new-metrics-v1 (latest) Signed-off-by: neilblaze <[email protected]> Co-Authored-By: Frank Zhao <[email protected]> * docs: added more metrics (x2) & fixed typos / broken URLs Signed-off-by: neilblaze <[email protected]> Co-Authored-By: Frank Zhao <[email protected]> * docs: update minor changes Signed-off-by: frank-zsy <[email protected]> --------- Signed-off-by: neilblaze <[email protected]> Signed-off-by: frank-zsy <[email protected]> Co-authored-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
* blog: ospp 2023 analysis Signed-off-by: frank-zsy <[email protected]> * feat: add table row style for even row Signed-off-by: frank-zsy <[email protected]> --------- Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
…ser (X-lab2017#38) Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
* refactor: update color theme Signed-off-by: frank-zsy <[email protected]> * refactor: update redis analysis english version Signed-off-by: frank-zsy <[email protected]> --------- Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: frank-zsy <[email protected]> Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: Bruce-Jay <[email protected]>
Signed-off-by: Bruce-Jay <[email protected]>
Bruce-Jay
force-pushed
the
dev_leaderboard
branch
from
d69f090 to
d422f6a
Compare
|
最新的提交完成了排行榜页面大致的开发，可以给出一些意见吗 |
|
/preview |
|
🪧The website for this PR is deployed at https://open-digger.cn/pull_34/ |
|
感觉很好，整体效果已经非常不错了。还有几个点可以优化一下： 1、这个页面可以把 footer 给去掉，就是页面最下方的版权和备案信息，可以更加沉浸式 |
|
另外： |
|
还有一个需求
|
|
备案区应该不是只保留首页，而是只在排行榜页面不显示，可以通过将这个页面的 Layout 中的 footer 设为 null 来实现 |
目前排行榜页面不是由 Layout 包裹的，Layout 包裹的是根组件。 但是如果让 Layout 包裹每一个单独的页面，我也找不到 user_docs, dev_docs, blogs 这几个文件在哪里设置（找不到对应的tsx文件）。所以想要保留其它页面的footer但是不保留排行榜页面的话，还是有些复杂的 |
|
剩下的部分我来修改吧，其实排行榜页面不应该是一个 mdx，而应该是一个 tsx，可以在 Layout 外侧通过 css 属性来隐藏 footer 部分的。我把 footer 部分的 Commit 删掉，然后改一下推上来看看。 |
|
另外我想确认一下 tailwind 在这次的 PR 里是做什么的啊，一定需要引入吗？ |
|
ok，感谢老师。tailwind 我原先想要引入的，但是发现好像引入失败了。那就算了吧，目的是为了让css的实现更加方便一些。 |
Signed-off-by: frank-zsy <[email protected]>
frank-zsy
force-pushed
the
dev_leaderboard
branch
from
3e9f595 to
4e096f5
Compare
|
/preview |
|
这次的提交里增加了中英文的内容支持，footer 样式优化，基础表格元素的滚动，css 样式模块化防止样式污染，css 冗余样式清除，js 文件改为 tsx 文件等。 @Bruce-Jay 可以帮忙测试一下看看。 仓库选取器还是有逻辑问题，我再看看如何修改。 |
|
🪧The website for this PR is deployed at https://open-digger.cn/pull_34/ |
Signed-off-by: frank-zsy <[email protected]>
|
/preview |
|
新的提交中使用了已封装的 SelectInput 组件作为项目选择器，同时移除了 tailwind 依赖库。 |
|
🪧The website for this PR is deployed at https://open-digger.cn/pull_34/ |
Signed-off-by: frank-zsy <[email protected]>
frank-zsy
force-pushed
the
dev_leaderboard
branch
from
3494835 to
8f2be63
Compare
Signed-off-by: frank-zsy <[email protected]>
|
/preview |
|
🪧The website for this PR is deployed at https://open-digger.cn/pull_34/ |
|
目前测试下来没有发现其他问题，这个 PR 将合入，该功能已基本完成。 |
Description
完成排行榜页面的初步开发
Resolved issues
#13
Before submitting the PR, please take the following into consideration
feat:,fix:,chore:,docs:, orrefactor:.mainbranch.