Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetTour.aspx 404s counted as failures #276

Open
pkgw opened this issue Dec 18, 2020 · 0 comments
Open

GetTour.aspx 404s counted as failures #276

pkgw opened this issue Dec 18, 2020 · 0 comments

Comments

@pkgw
Copy link
Contributor

pkgw commented Dec 18, 2020

Example: /wwtweb/gettour.aspx?GUID=0423ab7d-5339-43db-b9d6-c3713eeb9d23%25%27

I can see arguments in both directions, but I'm leaning towards marking these 404s as non-failures in the App Insights telemetry. At a minimum I think it would make sense to mark the underlying blob storage requests as non-failures if they 404.
pkgw added a commit to pkgw/wwt-website that referenced this issue Mar 26, 2021
@pkgw
WWT.Web: don't report missing tour blobs as App Insights errors
b7f5e8a 
Relevant to WorldWideTelescope#276. This is external user input so there will be bogus
values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pkgw