Unit tests: Add coverage for reusable blocks recursion warning #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Gutenberg 9.8.1, it's possible to insert a reusable block into itself. This creates an infinite recursion, triggering a server error (500), and possibly crashing the editor. (We seem to encounter the latter behavior more frequently, per the recent reusable blocks refactor.)
This has been recently fixed by @mcsf in Gutenberg (WordPress/gutenberg#28405 and WordPress/gutenberg#28428). (It was then amended by WordPress/gutenberg#28461 to continue to allow rendering of multiple non-nested reusable blocks in a post.)
Reusable blocks are covered by PHP unit tests found in
tests/phpunit/tests/blocks/render-reusable.php.This PR adds tests to:
Please note that these newly added tests will currently fail (e.g. in CI), unless the aforementioned Gutenberg PRs are carried over to WordPress!
(On a sidenote, in order to prevent regressions in the future, we should consider running Core's unit tests against PRs in the Gutenberg repo, see WordPress/gutenberg#26418).
Trac ticket: https://core.trac.wordpress.org/ticket/52364
cc/ @mcsf @gziolo @sirreal
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.