Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin PHP at 8.2 for Performance Tests on the 6.4 branch #6587

Closed

Conversation

joemcgill
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/60127


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@joemcgill joemcgill changed the title Pin PHP at 8.2 for Performance Tests Pin PHP at 8.2 for Performance Tests on the 6.4 branch May 20, 2024
@joemcgill
Copy link
Member Author

The Performance Tests are passing with PHP pinned to 8.2.

Copy link

github-actions bot commented May 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joemcgill, freewebmentor, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

@speedyprem speedyprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joemcgill
Copy link
Member Author

@desrosj, given the state of #6674 do you think we should commit this or wait and update the workflow in the 6.4 branch to use the new reusable workflow?

@desrosj
Copy link
Contributor

desrosj commented May 31, 2024

Because this is a unique fix that has not yet been committed to trunk/a later branch, let's merge this separately and then follow up with the changes in #6674, and then #6385.

@desrosj
Copy link
Contributor

desrosj commented Jul 24, 2024

@desrosj desrosj closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants