Post Content: Prevent infinite recursion #31455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
[Type] Bug
|
Size Change: -89 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gziolo
reviewed
May 4, 2021
| return ''; | ||
| } | ||
|
|
||
| $wrapper_attributes = get_block_wrapper_attributes( array( 'class' => 'entry-content' ) ); | ||
| $content = apply_filters( 'the_content', str_replace( ']]>', ']]>', $content ) ); |
There was a problem hiding this comment.
It'd be good to add a comment with a reference to where the filter is documented. It's a common pattern used in WordPress core and this file is going to be soon exposed there as well.
Completely unrelated to this PR but it should be nice to fix here since it isn't that much work.
gziolo
reviewed
May 4, 2021
| @@ -55,19 +57,41 @@ function Placeholder() { | |||
| ); | |||
| } | |||
|
|
|||
| function RecursionError() { | |||
There was a problem hiding this comment.
Interesting, maybe something that useNoRecursiveRenders should also expose?
There was a problem hiding this comment.
Hm, interesting. Btw, I made it a separate component because otherwise some of the ref-juggling hooks inside useBlockProps — specifically, useScrollIntoView — throw errors.
something that
useNoRecursiveRendersshould also expose?
This assumes apiVersion: 2, though, because of the use of useBlockProps. Is that acceptable?
There was a problem hiding this comment.
It would be good to confirm why useScrollIntoView causes issues, maybe it was called too late, React is very strict about all the rules of hooks? I don't mind having it in its own component though. I mostly curious to confirm it isn't some sort of bug with the hook.
gziolo
approved these changes
May 4, 2021
|
I believe
|
In fact, you can see the same issue when you go to the page where you can edit a given Reusable block or Template Part block. I would have to find my comment where I describe the same issue. Update: my related comment presenting exactly the same issue for Template Part block: |
This seems acceptable to me, no? I agree with Grzegorz that this experience will always be a little awkward, but the crucial thing is that we stop the recursion. |
Yes, it is fine to move forward. Fixing the issue might require changes to how the list of blocks is handled for those special cases. @ellatrix is looking into some slightly related changes to how |
Merged
7 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26593.
Analogous to #28405 and #28456.
Description
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).