Allow the query block to work on singular pages when inheriting the global query #28351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +25 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Jan 20, 2021
|
This is not safe as it would cause infinite loops when we have |
I just tested this and didn't see an issue... Could you elaborate on steps to replicate? |
In a single page:
|
Isn't it a general issue when using a Query block that contains Post Content child block and is embedded in the Post Content? Does it work any better when you explicitly pick posts (inherit option off) that contain Query block that nests Post Content? |
Yeah, this is not handled properly with just a small exception that with a custom query we use the value to exclude itself: This doesn't catch cases of course with cyclic references.... Maybe we can land this as it solves the main purpose of Query block, that is FSE and revisit all this recursive problem? |
|
I'm more inclined to prevent those infinite recursions by marking blocks in their definitions as vulnerable to that. In particular, I mean here that Post Content block can't nest another Post Content. The same applies to Template Part and Reusable blocks. I'm sure there is more. |
gziolo
added
[Block] Query Loop
|
Thank you both! |
IMO is not a blocker but I liked Miguel's approach and is fairly easy to to add it in this PR to |
|
@ntsekouras @gziolo Should we merge this one and deal with the recursion issue in a different PR (if it has not already been dealt with)? |
|
Yes, it makes sense to approach it this way 👍 |
gziolo
approved these changes
Feb 2, 2021
@ntsekouras: I couldn't find a PR to address the recursion in Post Content. Do we have one, or should we start a new PR? The one for Reusable Blocks is merged (#28405) and the one for Template Parts is in progress (#28456). |
We don't have one and we should create one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28334
How has this been tested?
Tested in an FSE theme with only an
index.htmltemplate containing a query block which inherits the global query.Before: The query was not rendering anything when viewing a
page(works for posts).After: The query properly renders the contents of the page.
Types of changes
Added an extra check in the query loop. If the post-type is empty and we're on a singular post/page/cpt, it will use that post's post-type for the query.
Checklist:
I've included developer documentation if appropriate.I've updated all React Native files affected by any refactorings/renamings in this PR.