Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows spaces in theme slugs.
(I thought this would be a much harder problem, but it was actually pretty easy.)
I realized that any time a slug with _'s needed to be replaced it was ALSO followed by a _ ( i.e. slug_name_function and never just slug_name). So replacing
old_slug_
withnew_slug_
was the answer.The order of replacement (replacing slugs with _'s first) had to be changed to make sure that when cloning a theme without _'s in the slug that the functions were correctly changed.
Fixes #228
To Test:
Observe that the new theme has the correct textdomain and it is used correctly throughout the theme (especially in PHP files with functions that use the theme slug such as
functions.php
).