Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Add JavaScript Unit Test #508

Merged
merged 2 commits into from
Feb 6, 2024
Merged

GitHub Actions: Add JavaScript Unit Test #508

merged 2 commits into from
Feb 6, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jan 16, 2024

This PR runs existing JavaScript unit tests on GitHub Actions.

Currently, unit tests are not run unless you run npm run test:unit locally. By incorporating it into GitHub Actions, we will be able to prevent regressions in advance, at least in the function that is the target of the tests.

GitHub Actions are already running in this PR. You will be able to see the test results under "Show al checks".

@t-hamano t-hamano changed the title WIP: GitHub Actions: Add JavaScript Unit Test GitHub Actions: Add JavaScript Unit Test Jan 16, 2024
@t-hamano t-hamano marked this pull request as ready for review January 16, 2024 13:53
Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@vcanales vcanales merged commit f67f921 into WordPress:trunk Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants