Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text domain to translation target #499

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Add text domain to translation target #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd7389
Add text domain to translation target
Olein-jp Dec 25, 2023
11b0359
Update update-panel.js
Olein-jp Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/editor-sidebar/create-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ export const CreateThemePanel = () => {
error.message && error.code !== 'unknown_error'
? error.message
: __(
'An error occurred while attempting to export the theme.'
'An error occurred while attempting to export the theme.',
'create-block-theme'
);
createErrorNotice( errorMessage, { type: 'snackbar' } );
}
Expand Down
10 changes: 7 additions & 3 deletions src/editor-sidebar/update-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ export const UpdateThemePanel = () => {
help={
<>
{ __(
'List the recommended plugins for this theme. e.g. contact forms, social media. Plugins must be from the WordPress.org plugin repository.'
'List the recommended plugins for this theme. e.g. contact forms, social media. Plugins must be from the WordPress.org plugin repository.',
'create-block-theme'
) }
<br />
<ExternalLink href="https://make.wordpress.org/themes/handbook/review/required/#6-plugins">
Expand All @@ -209,9 +210,12 @@ export const UpdateThemePanel = () => {
</>
}
// eslint-disable-next-line @wordpress/i18n-no-collapsible-whitespace
placeholder={ __( `Plugin Name
placeholder={ __(
`Plugin Name
https://wordpress.org/plugins/plugin-name/
Plugin Description` ) }
Plugin Description`,
'create-block-theme'
) }
value={ theme.recommended_plugins }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the translation domain (create-block-theme) is already there.

Copy link
Contributor Author

@Olein-jp Olein-jp Dec 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bdd7389

I added text domain here, but it gave me a JS syntax error, so I adjusted the whitespace separately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like the text domain was missing from here.

onChange={ ( value ) =>
setTheme( { ...theme, recommended_plugins: value } )
Expand Down
Loading