Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manage fonts page #485

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Fix manage fonts page #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fonts-sidebar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { _n } from '@wordpress/i18n';
import { __, _n } from '@wordpress/i18n';
import { useEffect, useState } from '@wordpress/element';
import { bytesToSize, localizeFontStyle } from '../utils';
import './fonts-sidebar.css';
import { Button } from '@wordpress/components';
import { trash } from '@wordpress/icons';
import { bytesToSize, localizeFontStyle } from '../utils';
import './fonts-sidebar.css';

function FontsSidebar( {
title,
Expand Down Expand Up @@ -39,7 +39,7 @@
} );
setFileSizes( sizes );
} );
}, [ fontsOutline ] );

Check warning on line 42 in src/fonts-sidebar/index.js

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has a missing dependency: 'flatfontsOutline'. Either include it or remove the dependency array

const variantsCount = Object.keys( fontsOutline ).reduce(
( acc, family ) => {
Expand Down
Loading