-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.4 #109
Comments
This is fantastic news that nvidia-xrun-pm finally got merged in! Sometime this weekend I will take my RPM spec I have been working on from your fork, place it in a separate GitHub repository, and update it to now use the upstream nvidia-xrun. |
I would also like to note that we should remove the RPM spec from this repository entirely, update the README documentation to point to my COPR (I will create a new one that will also support EL/Fedora/openSUSE), and then @Witko should tag a new nvidia-xrun release (0.4? 1.0?) on GtiHub. I would personally say this should be a 1.0 release to indicate the breaking changes. I will sent a PR to help with the first two steps. |
@ekultails what about the other repositories in COPR? Are they still maintained? (@AxelSilverdew) Regarding the version number I'm not sure that semantic versioning is used here, so it could also be a minor release, as usually 1 marks something that is quite stable. All of this decisions are to be made by @Witko really, so let's wait for him to anwser and see. |
The original I understand that versioning is out of my control, my opinion is that semantic versioning should be used. Changing the version scheme now would be a good time, too, considering the last tagged version was 0.3 from 3 years ago. |
@Witko @michelesr I opened up a PR to remove the spec file. My updated spec now handles building RPMs based on the git commit hash as to avoid the need to wait on new GitHub tags. I also published builds for all RPM based distributions (including Mageia, which I had missed with nvidia-xrun-pm). All of the relevant details are in the commit message and README updates. Let me know if you need anything else from my end. |
@ekultails great, if users have a way to install the new code without a release it's even better! In Arch Linux the nvidia-xrun-git package can be used to install from master branch, so I guess we can safely archive the fork once this is merged. |
Hi guys, i've merged the spec removal. Now i need to get my laptop working with nvidia card and then review the whole thing. And then a release would be nice. |
I've added few issues i'd like to incorporate or at least consider for 0.4 |
I can't find any reference in nvidia-run to bbswitch anymore. Is it not supported anymore? The method via /sys/bus/pci/*/power/control didn't even work for me when I last tried. Why don't you auto detect the presence of bbswitch and use bbswitch if present. That way, 0.4 wouldn't break working setups for people who use bbswitch. I'm using a Dell XPS 9560. |
I tested it in my friend's XPS 9560 and it seems to work fine (on Arch Linux). What's your setup? Can you be more specific about what's not working and maybe share some log? What's in your config file? The config file in this repository should work fine with XPS 9560.
|
I had pcie_port_pm=off in my kernel command line, because without it I would have problems. Since I have added that eons ago, I hope newer kernels fix the issues. TURN_OFF_GPU_ONLY=1 nvidia-xrun seems to work now and even survives a suspend to RAM cycle. I'm also using Arch Linux. |
I'm very hype for this release, hope I can see it soon! |
Asus UX480FD here, without bbswitch it doesn't ever turn off the GPU with and without PM |
Recently nvidia-xrun introduced a series of breaking changes, for example the new configuration file and the other changes introduced by merging nvidia-xrun-pm PR.
This means that a new (possibly major) version needs to be released and possibly package specs needs to be updated as well. The RPM spec seems to be quite outdated, maybe @ekultails can help with this (in fact it did the same for nvidia-xrun-pm but I didn't merge the changes as I wasn't sure of the current status of the nvidia-xrun repositories). Also is questionable whether is a good thing to maintain the RPM spec into the repository, maybe it can be moved out and maintained separately.
Once this is issues is closed nvidia-xrun-pm can be safely archived.
The text was updated successfully, but these errors were encountered: