From eb2f808b5a33255695888dfb402101e4f0893ec7 Mon Sep 17 00:00:00 2001 From: Sorin Patrasoiu Date: Tue, 16 Nov 2021 12:05:00 +0200 Subject: [PATCH] fix: fix diff validation Fix diff validation to have all strings lowercase, to avoid challenges when we have inconsistencies in different attributes (ProcessID vs. processid) --- change_analyzer/sequences_diff.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/change_analyzer/sequences_diff.py b/change_analyzer/sequences_diff.py index 771f1c5..8e17596 100644 --- a/change_analyzer/sequences_diff.py +++ b/change_analyzer/sequences_diff.py @@ -197,7 +197,7 @@ def _diff_is_valid(diff: str) -> bool: - script """ ignored_diffs = ['ProcessId', 'RuntimeId', 'script'] - return not any(ignored_diff in diff for ignored_diff in ignored_diffs) + return not any(ignored_diff.lower() in diff.lower() for ignored_diff in ignored_diffs) @staticmethod def _get_attribute_value_based_on_node(page_root: ET.Element, node: str, attribute: str) -> str: