Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NavViewEx #1698

Open
5 tasks
JerryNixon opened this issue Sep 28, 2019 · 2 comments
Open
5 tasks

Update NavViewEx #1698

JerryNixon opened this issue Sep 28, 2019 · 2 comments

Comments

@JerryNixon
Copy link
Member

JerryNixon commented Sep 28, 2019

There are several things wrong with it, yet it is close.

  • Get it to build, there are some things
  • Update it to use Nuget T10 packages
  • Update the sample app.
  • Update the .nuspec file
  • Upload to Nuget.org for Windows-XAML
@jp-weber
Copy link
Member

jp-weber commented Oct 1, 2019

I want work on point 1-3, because I have already implemented this in large parts of my fork. For me, it makes sense, if we use WinUI library for the NavigationView.

https://github.com/jp-weber/Template10/tree/master/Source/Template10.Extras.16299/Controls

In the sample project I am looking for better ways to set the header in a simple way. We could add all header templates to the shellpage resource list and set them as HeaderTemplates after navigation or loading. With a naming convention you could set here e.g. 'XHeaderTemplate'.

For the individual pages, e.g MainPage.xaml.cs you could now add the ViewModel of the page as (ShellPage).Header content, so that commands from the ViewModel can be added to the template.

@JerryNixon
Copy link
Member Author

One thing to consider is that I would like to break this out to its own Nuget package. I also think it might make sense to consider how (if) we can decouple it from Template10 so it would be useful outside of using the framework. Still not sure. Also, I only care about Template10 2 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants