Add Task Local Inject Setup behind new option #20
Conversation
| @@ -1,4 +1,5 @@ | |||
| import Foundation | |||
|
|
|||
| public final class Container { | |||
| private let localDependencyGraph: ThreadSafeDependencyGraph | |||
There was a problem hiding this comment.
Should this be removed now?
There was a problem hiding this comment.
we can remove it if we are certain we want task local to be the final way (then we can even remove the options in total or make it empty for now)
|
|
||
|
|
||
| public func copy() -> Self { | ||
| return Self(valuesByType: self.valuesByType) |
There was a problem hiding this comment.
I think we would want to create a new instance of the dictionary here which takes the values in, otherwise we have the same reference to a dict under the hood which could have issues with races I think (since this is a class not a struct)
There was a problem hiding this comment.
Since we are passing the dictionary into a new class, we should have a copy. Technically copy on write will make it the same instance, but it should be fine since those updates are atomic. What would be dangerous would be passing the ServiceDictionary itself, since that has a pointer to the actual same dictionary in multiple places and is definitely not sendable
Closes #19
Adds a way to inject values locally without locking. This allows us to do local injecting within local injecting since it will merge the two setups. All local injecting makes a copy of the currently injecting service dictionary, which allows us to have the class be sendable, since we never mutate the same underlying object.