Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluna-vault] Finalize Architecture in Luna/bLuna Vault to include sustainable withdrawal mechanics #19

Open
CyberHoward opened this issue Oct 12, 2021 · 3 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@CyberHoward
Copy link
Contributor

CyberHoward commented Oct 12, 2021

When withdrawing liquidity from the bluna vault, only the luna is returned. This could open us up to a bank run if everyone withdraws.

Either we repay in luna and bluna according to their share of the pool or the war-chest steps in and provides luna to the withdrawer in exchange for the bluna.
Edit: lp share does include bluna

@CyberHoward CyberHoward added the invalid This doesn't seem right label Oct 12, 2021
@CyberHoward CyberHoward self-assigned this Oct 12, 2021
@0xFable
Copy link
Contributor

0xFable commented Oct 13, 2021

Seen your edit, does this still need to be looked into ? Had a look at try_withdraw_liquidity in bLuna vault. Something if the current solution is not enough is we could potentially swap bLuna for Luna of course this has some potential for loss. Open to thoughts.

@CyberHoward
Copy link
Contributor Author

Yeah the current implementation is in line with the "withdraw profits immediately" ethos. But it opens us up to risks which we should address. If only bluna is left in the pool, other depositors are f*cked. Even if this wouldn't occur naturally it creates an attack vector i'm not comfortable with.

Those two proposed solutions still hold.

@SebastianJer7 SebastianJer7 changed the title [bluna-vault] Withdrawing tokens excludes the bluna held in the vault. [bluna-vault] Finalize Architecture in Luna/bLuna Vault to include sustainable withdrawal mechanics Oct 18, 2021
@SebastianJer7
Copy link

Howard and I need to work on the overall architecture of the luna/bluna vault, including the arb strategy, luna/bluna lp'ing, and withdrawal mechanics. This all connects with the bots and how they function so Ivan should probably be part of the conversation as well. This is one of the major issues that still needs sorted out for our V1.

0xFable pushed a commit that referenced this issue Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants