Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective values after refresh in blindfold state #91

Open
Whebon opened this issue Sep 6, 2024 · 0 comments
Open

Effective values after refresh in blindfold state #91

Whebon opened this issue Sep 6, 2024 · 0 comments
Labels
bug Something isn't working UI enchancement This is an optional improvement for the UI

Comments

@Whebon
Copy link
Owner

Whebon commented Sep 6, 2024

On a refresh in the blindfold state, the effective values are displayed for the "active player". This should instead be the player whose turn it is (which is temporarily not the active player).

In the code snippet below, it can be seen that updating the effective value checks for isCurrentPlayerActive. But it should be something like isCurrentPlayerTurn.

private updateEffectiveValue(card_div: HTMLElement) {
    let value = this.original_value;
    if (card_div.dataset['location'] == 'stock' && DaleCard.page?.isCurrentPlayerActive()) {
        value = this.effective_value;
    }
}
@Whebon Whebon added bug Something isn't working UI enchancement This is an optional improvement for the UI labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI enchancement This is an optional improvement for the UI
Projects
None yet
Development

No branches or pull requests

1 participant