Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "active_player_id" game state label (CT_CHEER) #107

Open
Whebon opened this issue Sep 13, 2024 · 0 comments
Open

Remove "active_player_id" game state label (CT_CHEER) #107

Whebon opened this issue Sep 13, 2024 · 0 comments
Labels
refactor This needs to be refactored to stay modular

Comments

@Whebon
Copy link
Owner

Whebon commented Sep 13, 2024

I assumed the reference to the active player gets lost when leaving an activeplayer state.
But that turns out to be false, so there is no need to store the "active_player_id" as a game state label.
Instead, to retrieve the last active player, I can just use $this->getActivePlayerId() in game/multipleactiveplayer states.

@Whebon Whebon added the refactor This needs to be refactored to stay modular label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor This needs to be refactored to stay modular
Projects
None yet
Development

No branches or pull requests

1 participant