Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding the initialization of the class 'GeneratorWithMap' #5

Open
yunfan0621 opened this issue Jun 24, 2021 · 0 comments
Open

Regarding the initialization of the class 'GeneratorWithMap' #5

yunfan0621 opened this issue Jun 24, 2021 · 0 comments

Comments

@yunfan0621
Copy link

Hi,

Thank you for sharing the code of the great work!

I have been adopt the code of the generator to my own project, and I am concerned with the following line of code:

self.to_rgbs.append(ToRGB(out_channel, style_dim))

I feel this line is unnecessary as the to_rgb layers are already initialized in

super(GeneratorWithMap, self)._initialize_styled( \

If I understand it corretly, the current version of code will double the amount of to_rgb layers, but only the first half are used in the forward process (the generation results are still good though).

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant