Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary changes not reflected in machinery results #13122

Open
2 tasks done
nijel opened this issue Nov 25, 2024 · 0 comments
Open
2 tasks done

Glossary changes not reflected in machinery results #13122

nijel opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@nijel
Copy link
Member

nijel commented Nov 25, 2024

Describe the issue

The machinery caching does not include glossary state for backends utilizing it. That can lead to showing outdated results in automatic suggestions.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Install machinery service supporting glossaries.
  2. Create a glossary entry for a term used in a string
  3. View automatic suggestions on that string
  4. Change the glossary term
  5. View automatic suggestions on that string again

Expected behavior

The automatic suggestion should reflect glossary changes.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Git checkout

Weblate versions

No response

Weblate deploy checks

No response

Additional context

get_cache_key for GlossaryMachineTranslationMixin should include a glossary checksum, most likely logic from get_glossary_id should be extracted and reused here.

@nijel nijel added the bug Something is broken. label Nov 25, 2024
@nijel nijel added this to the 5.9 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants