-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I can infinitely "Save" posts & pages while the plugin is active #205
Comments
I can confirm this issue exists and it's because of the metabox. However, I'm not yet sure as to what the solution can be as I just use the inbuilt WordPress Please see this issue as it's related to WordPress core directly: https://core.trac.wordpress.org/ticket/59395 |
I asked for you :) As you can see above. Hope it helps, in any way. |
Thanks. It does. However, I personally think this is not an ideal way forward as the meta box works well for now rather than me rewriting components in react, which is honestly time-consuming and painful! I am also not a fan of putting all this into the sidebar as a UI choice. I will eventually, but not immediately as the editor is still evolving and as you'll see in the link above that it's for WP6.6 and above. Another issue is, the panel will not work outside of Gutenberg and while I'll love to have the stats, I wouldn't be surprised a lot of people use the plugin in the Classic Editor which again means duplicating work. I know not the helpful answer but as the solo dev on this plugin with very few outside contributions, I need to prioritise various issues. I'm going to keep this open as I still think it's something to be resolved at the right time. |
I completely agree. Your reasoning is logical. |
Describe the bug
Without the plugin being active when I publish & save a post or page, the "Save" button becomes disabled and you can't save it again till there are any new changes (that's correct).
But when I activate the plugin I can keep pressing the "Save" button infinitely, even when there are no content changes.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Having the plugin active should not affect the behavior of the save button. The plugin should not prevent the "Save" button becoming disabled when there are no changes to the content.
Screenshots
In the video I first show how the plugin is inactive. Then I go & refresh the post, make a modification and save it. The button becomes disabled, each time. Also with the Page, I basically do the same.
Then, I go to the plugins and activate it. And repeat the same procedure, but this time I can infinitely save the page, without needing to make changes to the content. The save button doesn't become disabled.
https://youtu.be/l2J2lvO2ojk
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: