Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include JLPT tag in API word search result #35

Open
Nyankoo opened this issue May 5, 2022 · 6 comments
Open

Include JLPT tag in API word search result #35

Nyankoo opened this issue May 5, 2022 · 6 comments

Comments

@Nyankoo
Copy link

Nyankoo commented May 5, 2022

Is your feature request related to a problem? Please describe.
When using the API, found words don't include their JLPT tag while they're displayed on the website search

Describe the solution you'd like
The "words" json entry should contain the JLPT tag of that word

Describe alternatives you've considered

Additional context

@JojiiOfficial
Copy link
Member

I agree. I've already encountered this issue but unfortunately I don't want to change the API since it could break existing programs. I'm going to add a new version of the API which will include the JLPT information.

@Nyankoo
Copy link
Author

Nyankoo commented May 5, 2022

Thank you for the quick reply and I'm looking forward to it!

@Nyankoo
Copy link
Author

Nyankoo commented Jul 7, 2022

@JojiiOfficial Just quickly checking in on the progress of this.

@JojiiOfficial
Copy link
Member

This is currently out of scope. There is a new, undocumented, API which you could use but this can be changed later at any time. For a V2 I'd like to wait and collect more data that will be included in the new API version so we don't have to change the API all the time.

@keithfancher
Copy link

I came here to suggest the very same thing :D

I also wanted to suggest including the "main" example sentence that appears when you search for a term in the API search results.

Either that OR tag/sort the results returned when calling /api/search/sentences, so we can grab the "top" sentence. Right now, the sentences on the main search results aren't even guaranteed to be in that list, I realized. (Try searching via the API for , for example.)

I'd be happy to file a separate issue for this request if you'd prefer!

Separately, I also wanted to say: thank you for jotoba! It's awesome.

@keithfancher
Copy link

Oh, I just found the trello board... I guess we're on the same page 😄

Screenshot from 2024-03-14 14-36-38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants