Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using events rather than MpeInstrument#subscribe method #49

Open
odub opened this issue Jul 3, 2017 · 0 comments
Open

Switch to using events rather than MpeInstrument#subscribe method #49

odub opened this issue Jul 3, 2017 · 0 comments

Comments

@odub
Copy link
Contributor

odub commented Jul 3, 2017 •
edited
Loading

Relates to #19 and #48

Pros:

  • Allows a for multiple types of event to be emitted
  • Fits better with common event-based JS patterns (including Web MIDI API)

Cons:

  • Potentially a significant breaking API change
@odub odub changed the title Switch to using events rather than subscribe method Switch to using events rather than MpeInstrument#subscribe method Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@odub