Merge pull request #98 from WattRex/feature/HAL_PWM

feature/HAL_PWM Update definition for magic number MIN_PWM
WattRex · Jun 30, 2023 · d8f5fab · d8f5fab
2 parents 78b03f1 + 6f11a12
commit d8f5fab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/firmware/Sources/HAL/HAL_PWM/hal_pwm.c b/firmware/Sources/HAL/HAL_PWM/hal_pwm.c
@@ -23,7 +23,6 @@
 /*                     Definition of local symbolic constants                     */
 /**********************************************************************************/
 
-#define MIN_PWM 96
 /**********************************************************************************/
 /*                    Definition of local function like macros                    */
 /**********************************************************************************/
@@ -89,12 +88,12 @@ HAL_PWM_result_e HAL_PwmSetDuty(const uint32_t duty){
 
 	}
 	//If duty between max and min values
-	else if (duty>=MIN_PWM){
+	else if (duty>=HAL_PWM_MIN_PWM){
 		pwm_duty = duty;
 	}
 	else{
 		// Minimum duty to apply to the pwm is 96 by hardware with the actual configuration.
-		pwm_duty = MIN_PWM;
+		pwm_duty = HAL_PWM_MIN_PWM;
 	}
 
 	// Write the value to compare in the register.

diff --git a/firmware/Sources/HAL/HAL_PWM/hal_pwm.h b/firmware/Sources/HAL/HAL_PWM/hal_pwm.h
@@ -16,6 +16,8 @@
 /**********************************************************************************/
 /*                     Definition of local symbolic constants                     */
 /**********************************************************************************/
+#define HAL_PWM_MIN_PWM 96 
+/* This value depends on the prescaler of the HRTIM, go to documentation for more info */ 
 
 /**********************************************************************************/
 /*                    Definition of local function like macros                    */